Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MATLAB docker file with last 2024b version #224

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Update MATLAB docker file with last 2024b version #224

merged 3 commits into from
Feb 5, 2025

Conversation

aranega
Copy link
Contributor

@aranega aranega commented Jan 17, 2025

This PR updates the base version of MATLAB to 2024b, and updates the version of matnwb from 2.6.0.2 to 2.7.0

kabilar
kabilar reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aranega. Please also update the docker-test.yaml matrix and docker-push.yaml matrix so that we can automate the build/publishing through GitHub Actions.

@aranega
Copy link
Contributor Author

aranega commented Jan 17, 2025

@kabilar Thanks for the quick review! I'll update that asap. The PR is still in draft mode at the moment though as it depends on a PR on this repository. Well, the image can build without, but the live-script example will not be usable without some extra modifications.

@vijayiyer05
Copy link

FYI @aranega: I had a check-in with Ryan this week and he's now merged the dependent PR on the examples repository.

@aranega
Copy link
Contributor Author

aranega commented Jan 31, 2025

@vijayiyer05 thats perfect, thanks a lot 🙏!
I'll modify asap the build matrix and mark this PR as ready to review as soon as it's done

@aranega aranega marked this pull request as ready for review February 3, 2025 12:04
kabilar
kabilar approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aranega.

@kabilar kabilar merged commit 8a34ebc into dandi:main Feb 5, 2025
5 checks passed
@kabilar
Copy link
Member

kabilar commented Feb 5, 2025 •
edited
Loading

Confirmed that the MATLAB image built and pushed to Docker Hub. And successfully launched on DANDI Hub.

kabilar
kabilar reviewed Feb 5, 2025
View reviewed changes
images/Dockerfile.matlab
datalad-osf dandi nibabel nilearn pybids spikeinterface neo \
'pydra>=0.25' 'pynwb>=2.8.3' 'nwbwidgets>=0.10.2' hdf5plugin s3fs h5netcdf "xarray[io]" \
'pydra>=0.17' 'pynwb>=2.3.1' 'nwbwidgets>=0.10.2' hdf5plugin s3fs h5netcdf "xarray[io]" \
Copy link
Member

@kabilar kabilar Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally missed this but we should keep these upgrades. Filed #227.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! Sorry about this, I definitely mistook when I merged the code of the various tests I did.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabilar kabilar kabilar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aranega @vijayiyer05 @kabilar